this is the embedded dependency in maven plugins #1803
Conversation
Signed-off-by: Christian Schneider <chris@die-schneider.net>
| @@ -124,11 +124,6 @@ | |||
| <version>${project.version}</version> | |||
| </dependency> | |||
| <dependency> | |||
| <groupId>biz.aQute.bnd</groupId> | |||
There was a problem hiding this comment.
How is this delete related to adding the embedded repo to the plugns?
There was a problem hiding this comment.
it's just cleanup from a previous change! Is that not ok?
There was a problem hiding this comment.
OK, for some reason I thought #1794 removed the reference, but it was just in the project pom. So this is fine.
| <groupId>org.apache.maven.plugins</groupId> | ||
| <artifactId>maven-dependency-plugin</artifactId> | ||
| <version>2.10</version> | ||
| <configuration> |
There was a problem hiding this comment.
It is not clear to me that this configuration should be in the parent pom. It is shared by 2 of the plugins but if we need to use the dependency plugin in another plugin, that plugin may not need the embedded repo. This config should be in each project's pom.
rotty3000
changed the title
| <version>${project.version}</version> | ||
| <type>jar</type> | ||
| <overWrite>false</overWrite> | ||
| <outputDirectory>${project.build.directory}/classes</outputDirectory> |
There was a problem hiding this comment.
<outputDirectory>${project.build.outputDirectory}</outputDirectory>
There was a problem hiding this comment.
Sorry, do you mean I should replace the entire string including /classes?
There was a problem hiding this comment.
Yes. Using classes means failure if user uses a diff output folder.
| <version>${project.version}</version> | ||
| <type>jar</type> | ||
| <overWrite>false</overWrite> | ||
| <outputDirectory>${project.build.directory}/classes</outputDirectory> |
There was a problem hiding this comment.
<outputDirectory>${project.build.outputDirectory}</outputDirectory>
…s not present The same issue exists with `bnd-testing-maven-plugin` Signed-off-by: Raymond Auge <raymond.auge@liferay.com>
No description provided.