Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Style and code refactor #166

Merged
merged 19 commits into from Aug 5, 2021
Merged

Style and code refactor #166

merged 19 commits into from Aug 5, 2021

Conversation

bndw
Copy link
Owner

@bndw bndw commented Aug 4, 2021

This pull request includes the following changes:

  • Introduction of the Settings component. This component is responsible for all user-controlled settings.
  • Rename of the Card component to WifiCard. This component is now a basic WYSIWYG editor.
  • All shared state has been lifted up to App.js. Data is sent down into components and actions are raised up. App.js is responsible for managing shared state and composing components.
  • Hide password checkbox is no longer ever disabled. It's confusing to a user if the card is WYSIWYG but sometimes they're not able to control certain parts. Now a user can hide the password field, even if it doesn't pass validation -- if there are validation errors they'll get an error message on print with actionable directions.
  • A non-breaking copy change to wifi.password.hide, wifi.password.length.5 and wifi.password.length.8 that will need to be ported to all translations

There's still opportunity for more polish and refactoring, but given the [growing] size of this refactor I'd like to land it soon.

Give it a try at: https://dev.wificard.io
I'd appreciate any feedback from the community.

image

Fixes #111

@olekstomek
Copy link
Contributor

Big refactoring and lots of changes. 👏 I like the WYSIWYG approach.
A good lesson for me about Lifting State Up.
As for me, the changes are good and well-justified. A thumbs up 👍 on my side. 😉

@bndw bndw merged commit 093f025 into master Aug 5, 2021
@bndw bndw deleted the bndw/evergreen branch August 5, 2021 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove settings from card
3 participants