New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Style and code refactor #166
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will need a backfill for other translations
Baoyuantop
approved these changes
Aug 5, 2021
Big refactoring and lots of changes. 👏 I like the WYSIWYG approach. |
This was referenced Aug 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes the following changes:
Settings
component. This component is responsible for all user-controlled settings.Card
component toWifiCard
. This component is now a basic WYSIWYG editor.App.js
. Data is sent down into components and actions are raised up.App.js
is responsible for managing shared state and composing components.wifi.password.hide
,wifi.password.length.5
andwifi.password.length.8
that will need to be ported to all translationsThere's still opportunity for more polish and refactoring, but given the [growing] size of this refactor I'd like to land it soon.
Give it a try at: https://dev.wificard.io
I'd appreciate any feedback from the community.
Fixes #111