Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ability to set that WiFi network is hidden #101

Conversation

olekstomek
Copy link
Contributor

Issue: #96 and #95
Associated with: #39

I didn't test it with hidden network.
I will be grateful if someone tests it.

Default hidden SSID wifi network is disabled.

src/components/Card.js Outdated Show resolved Hide resolved
@olekstomek
Copy link
Contributor Author

I added wifi.name.hiddenSSID only in English language. If it is approved then it is worth adding translations of other languages.

@jiqinga
Copy link

jiqinga commented Jul 21, 2021

I tested the wifi network with hidden SSID and enabled Hidden SSID to connect successfully

@olekstomek
Copy link
Contributor Author

That's great, I'm glad!

Copy link
Owner

@bndw bndw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As mentioned in #89 (review) I think we need to figure out a solution for the increasing number of controls. I don't really want to continue adding items to the card as it's beginning to feel very busy. Maybe we add a collapsible/accordian "Advanced" section below the card? In there we could add various advanced features like:

  • size
  • hidden network
  • hide password
  • rotate

What do you think?

EDIT: Opened #111 to track the design change.

src/components/Card.js Outdated Show resolved Hide resolved
@olekstomek
Copy link
Contributor Author

As mentioned in #89 (review) I think we need to figure out a solution for the increasing number of controls. I don't really want to continue adding items to the card as it's beginning to feel very busy. Maybe we add a collapsible/accordian "Advanced" section below the card? In there we could add various advanced features like:

  • size
  • hidden network
  • hide password
  • rotate

What do you think?

EDIT: Opened #111 to track the design change.

Very good idea. I added more in comment #111 (comment)
(btw, I will implement your comments on this PR #89 soon)

@bndw
Copy link
Owner

bndw commented Aug 6, 2021

@olekstomek With #166 landed I think we have a good base to build this feature on - sorry for the delay 😅

@olekstomek
Copy link
Contributor Author

Ok, I did it and it's ready. :)

Copy link
Owner

@bndw bndw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! One change request on the label text, but aside from that I'm excited about this landing!

src/translations.js Outdated Show resolved Hide resolved
src/components/WifiCard.js Outdated Show resolved Hide resolved
@bndw bndw merged commit ade8bc7 into bndw:master Aug 8, 2021
@olekstomek olekstomek deleted the feature/possible-connection-to-hidden-ssid-wifi-network branch August 8, 2021 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants