-
-
Notifications
You must be signed in to change notification settings - Fork 465
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ability to set that WiFi network is hidden #101
ability to set that WiFi network is hidden #101
Conversation
I added |
I tested the wifi network with hidden SSID and enabled Hidden SSID to connect successfully |
That's great, I'm glad! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As mentioned in #89 (review) I think we need to figure out a solution for the increasing number of controls. I don't really want to continue adding items to the card as it's beginning to feel very busy. Maybe we add a collapsible/accordian "Advanced" section below the card? In there we could add various advanced features like:
- size
- hidden network
- hide password
- rotate
What do you think?
EDIT: Opened #111 to track the design change.
Very good idea. I added more in comment #111 (comment) |
@olekstomek With #166 landed I think we have a good base to build this feature on - sorry for the delay 😅 |
Ok, I did it and it's ready. :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! One change request on the label text, but aside from that I'm excited about this landing!
Issue: #96 and #95
Associated with: #39
I didn't test it with hidden network.
I will be grateful if someone tests it.
Default hidden SSID wifi network is disabled.