Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Geography search #53

Closed
ccicero opened this issue Aug 30, 2016 · 5 comments
Closed

Geography search #53

ccicero opened this issue Aug 30, 2016 · 5 comments
Assignees
Labels

Comments

@ccicero
Copy link

ccicero commented Aug 30, 2016

The new Geographic search function is great, thanks for implementing! Michelle said that it is parsing out the data from the section headings, is that correct? Shouldn't it only return those sections with that geography? e.g., I searched on "North America, Mexico, Baja California" and it returned a lot of notes that are not from Baja. See attached screen shot.

image

@jdeck88
Copy link
Member

jdeck88 commented Aug 30, 2016

I'm not sure this is a bug. The geographic search looks at section geographies but results are always returned by the volume. The volume itself may contain references to other sections, e.g. in the index or perhaps other sections that may precede in time or space the returned result that could be of interest. At any rate, if we do decide to return just sections as a result do we want to make this the default for all queries (e.g. for queries based on author name)? or, just queries based on geography? what about queries based on both geography and author name?

@ccicero
Copy link
Author

ccicero commented Aug 30, 2016

Christina explained where the data are coming from and that it's at the volume level. I think we at least need a little "i" icon with a pop-up window that explains that not all of the volumes have higher geography data populated yet, and that the query returns the entire volume even if just one section has that higher geography. Is that possible? Thanks.

@jdeck88
Copy link
Member

jdeck88 commented Aug 31, 2016

So, an "i" icon placed after Geography like:
unnamed

@jdeck88
Copy link
Member

jdeck88 commented Aug 31, 2016

This issue covers #54 so will be closing that one.

@ccicero
Copy link
Author

ccicero commented Aug 31, 2016

Yes, an "i" icon like in that image. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants