Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] - Create benchmark for Object creation and access #427

Closed
jasonwilliams opened this issue May 31, 2020 · 0 comments · Fixed by #472
Closed

[Feature Request] - Create benchmark for Object creation and access #427

jasonwilliams opened this issue May 31, 2020 · 0 comments · Fixed by #472
Assignees
Labels
benchmark Issues and PRs related to the benchmark subsystem. E-Easy Easy enhancement New feature or request good first issue Good for newcomers
Milestone

Comments

@jasonwilliams
Copy link
Member

In order to test the upcoming optimisation work we're doing around objects it would be good to have a benchmark for objects so we can see a before and after.

Example

Benchmarks live here
an object creation and access would be categorised under exec.

You can see the fibonacci benchmark here:
https://github.com/boa-dev/boa/blob/master/boa/benches/exec.rs#L49-L66

2 benchmarks could be made, 1 for accessing a value from an object, another for creating an object.

in order to run the benchmarks you can run cargo bench in the root folder

Contributing

https://github.com/boa-dev/boa/blob/master/CONTRIBUTING.md
https://github.com/boa-dev/boa/blob/master/docs/debugging.md

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
benchmark Issues and PRs related to the benchmark subsystem. E-Easy Easy enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants