Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Add benchmarks for long file lexing + parsing #430

Closed
Razican opened this issue May 31, 2020 · 0 comments · Fixed by #472
Closed

[Feature Request] Add benchmarks for long file lexing + parsing #430

Razican opened this issue May 31, 2020 · 0 comments · Fixed by #472
Assignees
Labels
benchmark Issues and PRs related to the benchmark subsystem. enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Milestone

Comments

@Razican
Copy link
Member

Razican commented May 31, 2020

Current situation
We currently don't have any benchmark checking how fast we lex and parse big files, but our current approach of reading the whole file into memory and only when we finish start lexing, and only when we finish lexing start parsing, all in one thread is far from optimal, especially for big files.

Benchmark explanation
We need a benchmark where we load a big JS file from disk (at least 5kB) and we lex + parse it.

Note that this file must only contain syntax that Boa understands. It can be a nonsense file, though, copy-pasting the same code multiple times.

It's important that the whole process is inside of the benchmark function, including reading the file from the disk, lexing it and parsing it.

@Razican Razican added enhancement New feature or request help wanted Extra attention is needed good first issue Good for newcomers benchmark Issues and PRs related to the benchmark subsystem. labels May 31, 2020
@Razican Razican added this to the v0.9.0 milestone May 31, 2020
@Razican Razican self-assigned this Jun 10, 2020
@Razican Razican linked a pull request Jun 10, 2020 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
benchmark Issues and PRs related to the benchmark subsystem. enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant