Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implemented #427, #429 and #430, and upgraded dependencies #472

Merged
merged 2 commits into from
Jun 10, 2020

Conversation

Razican
Copy link
Member

@Razican Razican commented Jun 10, 2020

This Pull Request resolves #427, #429 and #430.

It changes the following:

  • Adds a benchmark for long file lexing + parsing
  • Adds benchmarks for object creation + property access
  • Addes benchmarks for regular expression creation and execution.

Note: I also updated dependencies and removed the devcontainer and Docker files.

@Razican Razican added enhancement New feature or request benchmark Issues and PRs related to the benchmark subsystem. labels Jun 10, 2020
@Razican Razican added this to the v0.9.0 milestone Jun 10, 2020
@codecov
Copy link

codecov bot commented Jun 10, 2020

Codecov Report

Merging #472 into master will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #472      +/-   ##
==========================================
+ Coverage   66.44%   66.46%   +0.01%     
==========================================
  Files         146      147       +1     
  Lines        9376     9408      +32     
==========================================
+ Hits         6230     6253      +23     
- Misses       3146     3155       +9     
Impacted Files Coverage Δ
boa/src/exec/conditional/mod.rs 83.33% <0.00%> (-16.67%) ⬇️
boa/src/builtins/value/equality.rs 63.85% <0.00%> (-0.10%) ⬇️
boa/src/builtins/value/tests.rs 100.00% <0.00%> (ø)
boa/src/syntax/parser/statement/if_stm/mod.rs 84.21% <0.00%> (ø)
boa/src/syntax/parser/statement/break_stm/mod.rs 75.00% <0.00%> (ø)
boa/src/syntax/parser/statement/declaration/mod.rs 72.72% <0.00%> (ø)
...oa/src/syntax/parser/statement/continue_stm/mod.rs 75.00% <0.00%> (ø)
boa/src/builtins/value/val_type.rs 20.83% <0.00%> (ø)
boa/src/builtins/value/mod.rs 56.71% <0.00%> (+1.12%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ca80114...ab9d7d3. Read the comment docs.

@github-actions
Copy link

Benchmark for 4638570

Click to view benchmark
Test PR Benchmark Master Benchmark %
Create Realm 463.0±16.60µs 466.7±19.92µs -1.0000000000000009%
Dynamic Object Property Access (Execution) 18.3±0.34µs undefined +100%
Expression (Lexer) 2.0±0.03µs 2.1±0.05µs -3.0000000000000027%
Expression (Parser) 5.1±0.08µs 5.1±0.12µs -1.0000000000000009%
Fibonacci (Execution) 2.2±0.07ms 2.1±0.08ms +4.0000000000000036%
For loop (Execution) 64.8±2.57µs 64.3±0.96µs +1.0000000000000009%
For loop (Lexer) 5.4±0.16µs 5.4±0.16µs -1.0000000000000009%
For loop (Parser) 13.7±0.36µs 13.7±0.23µs 0%
Hello World (Lexer) 966.2±15.25ns 981.8±26.18ns -2.0000000000000018%
Hello World (Parser) 2.2±0.09µs 2.3±0.03µs -2.0000000000000018%
Long file (Parser) 6.2±0.13ms undefined +100%
Object Creation (Execution) 16.7±0.62µs undefined +100%
RegExp (Execution) 84.5±1.74µs undefined +100%
RegExp Literal (Execution) 92.7±3.24µs undefined +100%
RegExp Literal Creation (Execution) 86.4±5.77µs undefined +100%
Static Object Property Access (Execution) 16.8±0.27µs undefined +100%
Symbols (Execution) 17.7±0.72µs 18.0±0.94µs -2.0000000000000018%
undefined undefined +NaN%

@github-actions
Copy link

Benchmark for 2311fa6

Click to view benchmark
Test PR Benchmark Master Benchmark %
Create Realm 459.6±48.27µs 453.5±38.60µs +1.0000000000000009%
Dynamic Object Property Access (Execution) 17.9±1.49µs undefined +100%
Expression (Lexer) 2.1±0.20µs 2.0±0.16µs +1.0000000000000009%
Expression (Parser) 5.3±0.80µs 4.8±0.45µs +9.000000000000007%
Fibonacci (Execution) 2.4±0.23ms 2.3±0.24ms +4.0000000000000036%
For loop (Execution) 66.4±6.59µs 65.9±6.56µs +1.0000000000000009%
For loop (Lexer) 5.4±0.69µs 5.4±0.55µs +2.0000000000000018%
For loop (Parser) 13.6±1.80µs 14.1±1.65µs -4.0000000000000036%
Hello World (Lexer) 961.8±103.04ns 982.2±95.49ns -2.0000000000000018%
Hello World (Parser) 2.1±0.16µs 2.2±0.16µs -4.0000000000000036%
Long file (Parser) 6.2±0.37ms undefined +100%
Object Creation (Execution) 16.9±1.67µs undefined +100%
RegExp (Execution) 92.5±10.58µs undefined +100%
RegExp Literal (Execution) 105.9±11.66µs undefined +100%
RegExp Literal Creation (Execution) 90.0±8.39µs undefined +100%
Static Object Property Access (Execution) 18.6±2.12µs undefined +100%
Symbols (Execution) 16.9±1.59µs 18.9±2.23µs -12.00000000000001%
undefined undefined +NaN%

@Razican Razican merged commit 64dbf13 into master Jun 10, 2020
@Razican Razican deleted the new_benches branch June 10, 2020 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
benchmark Issues and PRs related to the benchmark subsystem. enhancement New feature or request
Projects
None yet
2 participants