Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): Support moves that don’t contribute to numMoves #646

Merged
merged 2 commits into from
Apr 26, 2020
Merged

feat(core): Support moves that don’t contribute to numMoves #646

merged 2 commits into from
Apr 26, 2020

Conversation

delucis
Copy link
Member

@delucis delucis commented Apr 24, 2020

This implements a long-form move syntax that prevents a move from incrementing numMoves and by extension triggering move limits. It would close #644.

This is a slightly naïve way of implementing this noLimit feature because as a consequence we completely lose track of those moves in the move counts. In theory we could track numMoves and limitNumMoves separately and trigger move limits using the latter, but it would make state and logic more complex. Let me know if you think it’s acceptable as is or if we should implement the more robust version.

Copy link
Member

@nicolodavis nicolodavis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@nicolodavis nicolodavis merged commit 2e5b902 into boardgameio:master Apr 26, 2020
@delucis delucis deleted the delucis/feat/moves-no-limit branch April 26, 2020 08:04
@tibo1902
Copy link

tibo1902 commented Nov 20, 2023

Hi,

Would it be possible to modify this functionality as follows:

add a moveCost property with a default value of 1. If it's set to 0, it will work as noLimit: true, with the possibility of setting higher costs for certain moves.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature request: excluding a move from the moveLimit.
3 participants