feat(core): Support moves that don’t contribute to numMoves #646
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements a long-form move syntax that prevents a move from incrementing
numMoves
and by extension triggering move limits. It would close #644.This is a slightly naïve way of implementing this
noLimit
feature because as a consequence we completely lose track of those moves in the move counts. In theory we could tracknumMoves
andlimitNumMoves
separately and trigger move limits using the latter, but it would make state and logic more complex. Let me know if you think it’s acceptable as is or if we should implement the more robust version.