forked from rojo-rbx/rojo
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Add check to ensure plugin version matches cargo version (rojo-rbx#794)
This modifies Rojo's build script to throw a fit if we're building a plugin with a semver incompatible version. In the process, it moves the version of the plugin to a file named `Version.txt` that's parsed at runtime. This should be minimally invasive but it's technically worse for performance than the hardcoded table and string we had before. This feels better than a CI check or just manually verifying because it makes it physically impossible for us to forget since Rojo won't build with it being wrong.
- Loading branch information
Showing
6 changed files
with
60 additions
and
28 deletions.
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
7.3.0 |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,25 +1,27 @@ | ||
{ | ||
"name": "Rojo", | ||
"tree": { | ||
"$className": "Folder", | ||
"Plugin": { | ||
"$path": "src" | ||
}, | ||
"Packages": { | ||
"$path": "Packages", | ||
|
||
"Log": { | ||
"$path": "log" | ||
}, | ||
"Http": { | ||
"$path": "http" | ||
}, | ||
"Fmt": { | ||
"$path": "fmt" | ||
}, | ||
"RbxDom": { | ||
"$path": "rbx_dom_lua" | ||
} | ||
} | ||
} | ||
} | ||
"name": "Rojo", | ||
"tree": { | ||
"$className": "Folder", | ||
"Plugin": { | ||
"$path": "src" | ||
}, | ||
"Packages": { | ||
"$path": "Packages", | ||
"Log": { | ||
"$path": "log" | ||
}, | ||
"Http": { | ||
"$path": "http" | ||
}, | ||
"Fmt": { | ||
"$path": "fmt" | ||
}, | ||
"RbxDom": { | ||
"$path": "rbx_dom_lua" | ||
} | ||
}, | ||
"Version": { | ||
"$path": "Version.txt" | ||
} | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters