Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Internal component class in component route #64

Closed
da-ekchajzer opened this issue Mar 23, 2022 · 0 comments
Closed

Internal component class in component route #64

da-ekchajzer opened this issue Mar 23, 2022 · 0 comments
Assignees
@da-ekchajzer
Labels
bug Something isn't working

Comments

@da-ekchajzer
Copy link
Collaborator

Bug description

Component route consumes internal components class instead of DTO.
http://api.boavizta.org:5000/docs ⇾ Schemas

  • CPU | ComponentCPU
  • Case | ComponentCase
  • PowerComponent | ComponentPowerComponent
  • Disk | ComponentHDD, ComponentSSD

Component* Objects should be internal objects. External object should be DTOs.

Expected behavior

Component route should consume component DTO
@da-ekchajzer da-ekchajzer added the bug Something isn't working label Mar 23, 2022
@da-ekchajzer da-ekchajzer self-assigned this Mar 23, 2022
da-ekchajzer pushed a commit that referenced this issue Mar 30, 2022
fixing #64
ef4f374
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@da-ekchajzer da-ekchajzer

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@da-ekchajzer