Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Iodine.unsubscribe crashes when called with symbol. #134

Closed
raxoft opened this issue Dec 9, 2022 · 4 comments
Closed

Iodine.unsubscribe crashes when called with symbol. #134

raxoft opened this issue Dec 9, 2022 · 4 comments

Comments

@raxoft
Copy link
Contributor

raxoft commented Dec 9, 2022

System Information

  • OS: Linux 4.15.0
  • Ruby: 2.7.6
  • Version: 0.7.51
  • OpenSSL: OpenSSL 1.1.1 11 Sep 2018

Description

Despite the fact that subscribe and publish seem to work with symbols which are also used in examples, calling Iodine.unsubscribe with symbol crashes immediately.

Testing code

require 'iodine'
Iodine.unsubscribe(:foo)

Expected behavior

It should not crash.

Actual behavior

It segfaults. It works only when string is used.

@boazsegev
Copy link
Owner

Hi @raxoft ,

Thank you for opening this issue, as well as PR #133. I'm releasing a fix that I hope would help, it should be up on RubyGems any moment.

Thanks!
Bo.

@raxoft
Copy link
Contributor Author

raxoft commented Dec 13, 2022

Thanks, @boazsegev, for fixing this so quickly. I have found one more issue regarding :enter_master event and subscribing, but I didn't have time to craft the standalone example yet. Will post it once I do later this week. Thanks again.

@raxoft
Copy link
Contributor Author

raxoft commented Dec 13, 2022

Also, I am not Alexander Pavlenko, but that's ok. :)

@boazsegev
Copy link
Owner

Hi Patrick,

Thank you for opening these issues and helping improve iodine. I'm sorry about the copy and paste errors both in the code and the credit you deserve in the changeling (both, hopefully, are now fixed).

And you're welcome.

B.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants