Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

container-transact #60

Closed
seyfahni opened this issue Apr 19, 2016 · 5 comments
Closed

container-transact #60

seyfahni opened this issue Apr 19, 2016 · 5 comments

Comments

@seyfahni
Copy link
Contributor

Even if you enable logging for all three container-transact, container-insert and container-extract you can search for container-transact and will not get any results.

It might be useful, if container-transact could be used as short-cut for container-insert and container-extract.

On the other side, if container-transact should be removed in the future, it would be nice to print a warning that there won't be any new logs, because they are now split into container-insert and container-extract.

Anyway, container-transact should be omitted from configuration.

@bob7l
Copy link
Owner

bob7l commented Apr 20, 2016

Yeah the only issue with "omitting" this old value is we'll have to hardcode it out, which really drags down the maintainability and cleanness.

I might end up just removing it completely. The newer 1.7+ builds wont work correctly on prior databases anyways. And our datatypes all contain manually defined id's (Thank god we don't use ordinals xD).

@RoboMWM
Copy link

RoboMWM commented Apr 20, 2016

Are these config options replaced by container-transaction? If so, should I set these options to false until they're removed? (I currently have them set to true.)

@bob7l
Copy link
Owner

bob7l commented Apr 20, 2016

No the container-transaction variable is deprecated and has been replaced with container-insert and container-extract. Having container-transaction: true within the config wont change anything aside from storing the true value in memory for the container-transaction.

I'm most likely going to completely remove container-transaction from the next update as it's been completely replaced.

@RoboMWM
Copy link

RoboMWM commented Apr 20, 2016

Oh ok so he's just been spelling it wrong and I somewhat misread. So container-insert and extract are the replacement nodes then?

@seyfahni
Copy link
Contributor Author

seyfahni commented Apr 20, 2016

Yes, they are a replacement. Sorry for my spelling mistakes, I'm not a native English-speaking person.

@bob7l bob7l closed this as completed Aug 8, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants