-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
container-transact #60
Comments
Yeah the only issue with "omitting" this old value is we'll have to hardcode it out, which really drags down the maintainability and cleanness. I might end up just removing it completely. The newer 1.7+ builds wont work correctly on prior databases anyways. And our datatypes all contain manually defined id's (Thank god we don't use ordinals xD). |
Are these config options replaced by |
No the container-transaction variable is deprecated and has been replaced with container-insert and container-extract. Having container-transaction: true within the config wont change anything aside from storing the true value in memory for the container-transaction. I'm most likely going to completely remove container-transaction from the next update as it's been completely replaced. |
Oh ok so he's just been spelling it wrong and I somewhat misread. So |
Yes, they are a replacement. Sorry for my spelling mistakes, I'm not a native English-speaking person. |
Even if you enable logging for all three
container-transact
,container-insert
andcontainer-extract
you can search for container-transact and will not get any results.It might be useful, if
container-transact
could be used as short-cut forcontainer-insert
andcontainer-extract
.On the other side, if
container-transact
should be removed in the future, it would be nice to print a warning that there won't be any new logs, because they are now split intocontainer-insert
andcontainer-extract
.Anyway,
container-transact
should be omitted from configuration.The text was updated successfully, but these errors were encountered: