Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trace shutdown processing needs to be after other shutdown processing #31

Open
bobbingwide opened this issue Mar 24, 2016 · 2 comments
Open
Assignees

Comments

@bobbingwide
Copy link
Owner

The trace log that I used when analyzing Automattic/jetpack#3579 showed Jetpack's shutdown processing after oik-bwtrace's. oik-bwtrace should hook into shutdown later than it currently does.

@bobbingwide
Copy link
Owner Author

Actually, Jetpack's shutdown processing does occur before oik-bwtrace's, but Yoast's doesn't

/home/oikcouk/public_html/wp-content/plugins/oik-bwtrace/includes/bwtrace-actions.php(410:) bw_trace_attached_hooks(3) 583 2016-03-24T10:12:51+00:00 17.757882 0.005582 cf=shutdown 41 0 47137224/50456496 F=529 shutdown 
: 0   bw_trace_attached_hooks;9
: 1   wp_ob_end_flush_all;1
: 8   Jetpack_Sync::register_all_options;1 Jetpack_Sync::register_all_module_constants;1
: 9   Jetpack_Sync::sync;1
: 10   bw_trace_count_report;1 bw_trace_included_files;1 bw_trace_saved_queries;1 bw_trace_status_report;1 Yoast_Notification_Center::set_transient;1

Note: Jetpack attaches different hooks with different priorities dependent upon the context. See the rather out of date http://jetpack.wp-a2z.org/oik_hook/shutdown/

@bobbingwide
Copy link
Owner Author

JetPack's Sync logic has now changed. See bobbingwide/oik-clone#15

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant