Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

URL without trailing '/' after address causes crash on ESP32 #30

Closed
thorlancaster opened this issue Nov 8, 2020 · 1 comment
Closed

Comments

@thorlancaster
Copy link

When attempting to connect to a HTTP server, I found that URLs where the address portion was not ended with a '/' character caused a crash.

URLs that cause crash: http://172.105.151.207, http://172.105.151.207:1230, http://172.105.151.207:1230?foo=bar
URLs that don't cause crash: http://172.105.151.207/, http://172.105.151.207:1230/, http://172.105.151.207:1230/?foo=bar.

(Note: The IP address, especially port 1230, will likely change in the future, but I hope you see the pattern).

It's easy enough to fix on my end by adding a '/' to the URL between the address and the arguments, but this shouldn't be happening.

boblemaire added a commit that referenced this issue Nov 18, 2020
Started with issue #30 where crashed when query w/o path.  Now always produces root path ('/') when path omitted.
@boblemaire
Copy link
Owner

Resolved in rewrite of parseURL PR#32

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants