Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Partial tiles with some images #113

Closed
BeebBenjamin opened this issue Jun 5, 2024 · 3 comments
Closed

Partial tiles with some images #113

BeebBenjamin opened this issue Jun 5, 2024 · 3 comments
Assignees
@BeebBenjamin
Labels
priority: high Issue needs addressing before medium and low issues status: testing PR/MR is being tested on QA type: bug Something isn't working

Comments

@BeebBenjamin
Copy link
Contributor

Due to differences in the keys used to get textures when we get to the three.js layer (caused by a rounding error, the difference of 1 pixel) the last row of tiled meshes is missing textures and rendered visible = False.

The fix is to make sure our tiling helper method uses the same rounding method as OpenSeadragon.
@BeebBenjamin
Copy link
Contributor Author

I am testing a fix.

@BeebBenjamin BeebBenjamin self-assigned this Jun 5, 2024
@BeebBenjamin BeebBenjamin added type: bug Something isn't working priority: high Issue needs addressing before medium and low issues status: testing PR/MR is being tested on QA labels Jun 5, 2024
@BeebBenjamin
Copy link
Contributor Author

OpenSeadragon uses Math.floor instead of Math.ceil.

@BeebBenjamin
Copy link
Contributor Author

Fix is on QA for testing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@BeebBenjamin BeebBenjamin

Labels
priority: high Issue needs addressing before medium and low issues status: testing PR/MR is being tested on QA type: bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@BeebBenjamin