Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

maxXhrRetries should be lowered #80

Closed
allanbowe opened this issue Jul 8, 2019 · 1 comment
Closed

maxXhrRetries should be lowered #80

allanbowe opened this issue Jul 8, 2019 · 1 comment

Comments

@allanbowe
Copy link
Contributor

Some customers (even on M6) are getting an "Unable to load Workspaces" error due to the maxing out of multibridge connections / queue slots when errors are thrown. Workarounds:

  • increase multibridge connections from 3
  • manually apply maxXhrRetries to a lower number

The default of 5 retries is pretty high, as this can mean 18 requests if an app has, say, three calls that all error.

Perhaps a better default should be 2 (meaning, 3 requests per service if they all error). Or even, zero.

@boomskats
Copy link
Contributor

The answer to this is to avoid designs that require calling multiple services in parallel (as a best practice), and to implement graceful error handling within the SAS code (which you've done in #81).

If neither is possible and this is still required, maxXhrRetries can be overridden when instantiating a new adapter in the config json - something along the lines of this:

var adapter = new h54s({ maxXhrRetries: 1 });

Closing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants