Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggested installation command requires R.rsp #14

Open
alexploner opened this issue Sep 8, 2022 · 1 comment
Open

Suggested installation command requires R.rsp #14

alexploner opened this issue Sep 8, 2022 · 1 comment

Comments

@alexploner
Copy link

Totally minor detail: running the proposed installation command from the README

remotes::install_github("boennecd/VAJointSurv", build_vignettes = TRUE)

assumes that R.rsp is installed, but it's only listed as suggested in the DESCRIPTION file, so it fails e.g. if you work from a fresh R install.

Literally the least of my problems - thanks for a great package!

@ellessenne
Copy link
Collaborator

Hi @alexploner (and cc @boennecd),

This can be solved by adding the dependencies = TRUE argument to install_github():

remotes::install_github("boennecd/VAJointSurv", build_vignettes = TRUE, dependencies = TRUE)

This was tested on a fresh Ubuntu 22.04.01 VM with R 4.2.1, and the cost of this was the installation of these additional (23) packages: R.utils, R.oo, R.methodsS3, xfun, stringi, yaml, stringr, highr, fastmap, base64enc, htmltools, rappdirs, memoise, cachem, jquerylib, sass, R.cache, tinytex, knitr, bslib, R.rsp, xml2, rmarkdown.

@boennecd, if you think adding this is okay I can make a quick PR!
My understanding is that this is some sort of worst-case scenario in terms of dependencies, as, according to the documentation of install_github():

Can be a character vector (selecting from "Depends", "Imports", "LinkingTo", "Suggests", or "Enhances"), or a logical vector.
TRUE is shorthand for "Depends", "Imports", "LinkingTo" and "Suggests".
NA is shorthand for "Depends", "Imports" and "LinkingTo" and is the default.
FALSE is shorthand for no dependencies (i.e. just check this package, not its dependen-
cies).
The value "soft" means the same as TRUE, "hard" means the same as NA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants