Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix yield for ESP8266 #81

Closed
wants to merge 2 commits into from
Closed

Fix yield for ESP8266 #81

wants to merge 2 commits into from

Conversation

g3rb3n
Copy link

@g3rb3n g3rb3n commented Sep 4, 2017

Hi,

The yield code seems to make my ESP's crash. The ESP has a watch dog timer feed function for long running processes. I have implemented this for the ESP8266 only by using macros. I have tested this on the ESP8266, but I did not check if it has any side effects for other boards.

Cheers!

@amotl
Copy link
Contributor

amotl commented Feb 20, 2019

Dear @g3rb3n,

we fixed these kinds of issues by introducing a delay(0) at appropriate places, which should also feed the watchdog timer on the ESP8266. However, thanks for learning about ESP.wdtFeed() from your contribution.

Please let us know if you still have issues with the current version of this library, otherwise enjoy and thanks again!

With kind regards,
Andreas.

P.S.: As being superseded by merging #123, we might close this now.

@g3rb3n
Copy link
Author

g3rb3n commented Feb 21, 2019

Hi Andreas,

delay(0) has a WDT feed as a side effect, so this will work fine as well. And it does save us a macro statement.

Kind regards,

Gerben

@g3rb3n g3rb3n closed this Feb 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants