Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Potential minor bug #1

Closed
tst2005 opened this issue Jul 26, 2019 · 1 comment
Closed

Potential minor bug #1

tst2005 opened this issue Jul 26, 2019 · 1 comment

Comments

@tst2005
Copy link

tst2005 commented Jul 26, 2019

I just read the code and see a potential mistake
in https://github.com/BoHeck/Annotorio/blob/master/data.lua#L3
To hide all technologies, the value v.hidden should be set to true instead of false, no ?

 --Hiding all existing technologies
 for i, v in pairs(data.raw.technology) do
-  v.hidden = false
+  v.hidden = true
   v.enabled = false
 end
@BoHeck
Copy link
Owner

BoHeck commented Jul 29, 2019

the prototype Technology has the attribute

visible_when_disabled
Type: Types/bool
Default: false

so that hidden wont matter unless its enabled. I dont want to hide them in case some other mod reactivates them. This way its also easier to catch a mistake

@BoHeck BoHeck closed this as completed Jul 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants