add support for obj, dll, and coff object file formats #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bojand
changed the title
Comment on lines
+109
to
+122
| /// Returns whether a buffer is a Common Object File Format for i386 architecture. | ||
| pub fn is_coff_i386(buf: &[u8]) -> bool { | ||
| buf.len() > 2 && buf[0] == 0x4C && buf[1] == 0x01 | ||
| } | ||
|
|
||
| /// Returns whether a buffer is a Common Object File Format for x64 architecture. | ||
| pub fn is_coff_x64(buf: &[u8]) -> bool { | ||
| buf.len() > 2 && buf[0] == 0x64 && buf[1] == 0x86 | ||
| } | ||
|
|
||
| /// Returns whether a buffer is a Common Object File Format for Itanium architecture. | ||
| pub fn is_coff_ia64(buf: &[u8]) -> bool { | ||
| buf.len() > 2 && buf[0] == 0x00 && buf[1] == 0x02 | ||
| } |
There was a problem hiding this comment.
I think we should also have a generic is_coff function, and register that as a matcher instead of all of the specific ones
src/matchers/app.rs
Outdated
Comment on lines
35
to
39
| /// Returns whether a buffer is a DLL. | ||
| pub fn is_dll(buf: &[u8]) -> bool { | ||
| is_exe(buf) | ||
| } | ||
|
|
There was a problem hiding this comment.
The fact that we can't distinguish between dll and exe should also be documented here.
paolobarbolini
approved these changes
Mar 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #33.
exeanddllhave the same magic number