Update Band when the model is changed #10216
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
p-himik
commented
Jun 22, 2020
p-himik
commented
- issues: fixes [BUG] Band is not updated when the model is changed #10215
- tests added / passed
- release document entry (if new feature or API change)
p-himik
commented
Jun 22, 2020
| this.connect(this.model.change, update) | ||
| this.connect(this.model.source.streaming, update) | ||
| this.connect(this.model.source.patching, update) | ||
| this.connect(this.model.source.change, update) |
There was a problem hiding this comment.
This pattern is repeated in many places, and it just asks for this.connect to be able to receive an array of signals. This would also allow reuse of new_slot within connect. @mattpap What do you think?
There was a problem hiding this comment.
That would be useful in general. However, in this case, this code most likely will be removed soon, as I will be bringing all vectorizable (or source-driven) renderers under one implementation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.