Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix over-quoting by components #10271

merged 1 commit into from Jul 8, 2020


Copy link

@bryevdv bryevdv commented Jul 8, 2020

ref: #10268 (comment)

@mattpap since the "only replace single quotes" is only needed in one place I just used str.replace plus a (now-appropriately-called) stdlib html.escape

Copy link
Member Author

bryevdv commented Jul 8, 2020

@mattpap FYI I'll plan to merge this at the end of my day unless you ask for more time or changes.

@bryevdv bryevdv changed the title fix over-quoting fix over-quoting by components Jul 8, 2020
@mattpap mattpap merged commit 253bc4e into branch-2.2 Jul 8, 2020
@mattpap mattpap deleted the bryanv/fix_components_escaping branch Jul 8, 2020
paul-tqh-nguyen pushed a commit to paul-tqh-nguyen/bokeh that referenced this pull request Jul 9, 2020
@mattpap mattpap linked an issue Jul 26, 2020 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet

Successfully merging this pull request may close these issues.

[BUG] bokeh.embed.components outputs escaped javascript
2 participants