Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't configure z-index on root elements #11388

Merged
merged 2 commits into from
Jul 2, 2021
Merged

Conversation

mattpap
Copy link
Contributor

@mattpap mattpap commented Jun 29, 2021

This PR should fix problems with all tooltip-like components, as long as they use .bring-to-front() Less mixin.

TODO:

  • visual tests

fixes #11365

@mattpap mattpap merged commit 3ad2c90 into branch-2.4 Jul 2, 2021
@mattpap mattpap deleted the mattpap/11365_z_index branch July 2, 2021 13:28
mattpap added a commit that referenced this pull request Jul 2, 2021
* Don't configure z-index on root elements

* Add visual regression tests
mattpap added a commit that referenced this pull request Jul 5, 2021
* Upgrade to Chrome 91 and fix failing examples' tests (#11320)

* Show version number in test:{run,spawn}:headless

* Don't assume style.margin* are defined

* Prefer chrome over chromium

* Update baselines

* Fix rendering of legends for ellipse glyph (#11368)

* Handle corner cases in LinearLinterpolationScale.v_compute() (#11370)

* Fix data access layout `SpatialIndex.bounds()` (#11379)

* Fix data access layout SpatialIndex.bounds()

* Resolve mypy's errors with numpy >= 1.21

* app_index.html missing quotes in href attribute (#11385)

* Use an exact extension's version in a CDN URL (#11387)

* Allow to scroll to the initial active tab (#11391)

* Allow to scroll to the initial active tab

* Add visual tests

* Restore support for relative font size units (#11397)

* Restore support for relative font size units

* Add visual regression tests

* Don't configure `z-index` on root elements (#11388)

* Don't configure z-index on root elements

* Add visual regression tests

* Revert layout to pre PR #10779 state (#11394)

* Revert layout regression fixes

* Revert color bar layout related changes

* Work around Grid's alignment bugs and limitations

* Resolve mypy's complaints

Co-authored-by: Dan Lester <dan@ideonate.com>
@bryevdv bryevdv added this to the 2.3.3 milestone Sep 24, 2021
bryevdv pushed a commit that referenced this pull request Dec 13, 2021
* Don't configure z-index on root elements

* Add visual regression tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] dropdown menu is hidden in multi choice, others are not
2 participants