Fix usage of external hatch patterns in visual properties #11650
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattpap
force-pushed
the
mattpap/11646_hatch_image
branch
from
51cdaa0
to
b2379c1
Compare
bryevdv
approved these changes
Sep 20, 2021
|
Test failure is unrelated (#11549). |
bryevdv
pushed a commit
that referenced
this pull request
Sep 24, 2021
* Fix initialization order in visual properties * Make ImageURLTexture model non-abstract * Add visual regression tests
bryevdv
pushed a commit
that referenced
this pull request
Sep 27, 2021
* Fix initialization order in visual properties * Make ImageURLTexture model non-abstract * Add visual regression tests
bryevdv
pushed a commit
that referenced
this pull request
Dec 13, 2021
* Fix initialization order in visual properties * Make ImageURLTexture model non-abstract * Add visual regression tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note this bug only affects grid bands, etc., i.e. visual properties, but not scalar or vector visuals.
fixes #11646