JS document callbacks and disconnect event #12370
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
mattpap
commented
Sep 11, 2022
•
mattpap
commented
- maybe Need indication on disconnect/session timeout #3519
- fixes Hook for callback upon document init #4272
- fixes [FEATURE] Add JS event on Websocket disconnect #11328
mattpap
commented
Sep 11, 2022
Codecov Report
@@ Coverage Diff @@
## branch-3.1 #12370 +/- ##
===========================================
Coverage 92.32% 92.33%
===========================================
Files 314 314
Lines 19797 19831 +34
===========================================
+ Hits 18277 18310 +33
- Misses 1520 1521 +1 |
mattpap
force-pushed
the
mattpap/11328_disconnect_event
branch
3 times, most recently
from
59de962
to
b7875d4
Compare
mattpap
force-pushed
the
mattpap/11328_disconnect_event
branch
2 times, most recently
from
87034fc
to
276203f
Compare
14 tasks
mattpap
force-pushed
the
mattpap/11328_disconnect_event
branch
from
276203f
to
4662b53
Compare
mattpap
force-pushed
the
mattpap/11328_disconnect_event
branch
from
4662b53
to
de5e846
Compare
mattpap
force-pushed
the
mattpap/11328_disconnect_event
branch
from
de5e846
to
a77406d
Compare
bryevdv
reviewed
Feb 10, 2023
mattpap
force-pushed
the
mattpap/11328_disconnect_event
branch
from
289dbcd
to
3e5f673
Compare
|
@mattpap I would suggest adding and new subsection and example code snippet here: https://docs.bokeh.org/en/latest/docs/user_guide/interaction/js_callbacks.html#examples It doesn't have to be a complete example (just a code block will do) since it is for apps which won't "work" on the docs, but the goal is to have a defined URL that we can point users to for discussion about this important feature. |
mattpap
force-pushed
the
mattpap/11328_disconnect_event
branch
from
3e5f673
to
2c10df4
Compare
bryevdv
approved these changes
Feb 20, 2023
Chiemezuo
pushed a commit
to Chiemezuo/bokeh
that referenced
this pull request
Aug 27, 2024
* JS document callbacks and disconnect event * Improve Document.on_event() API in JS * Redesign handling of connection events * Move doc_js_events under interaction/js_callbacks * Make show()/save() respect curdoc's JS callbacks * Make examples' tests work * Add Document.js_on_event() to match Model's API * Add preliminary documentation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.