New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for string nodes to StaticLayoutProvider
#13618
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## branch-3.4 #13618 +/- ##
==============================================
+ Coverage 92.54% 92.55% +0.01%
==============================================
Files 323 323
Lines 20493 20509 +16
==============================================
+ Hits 18965 18983 +18
+ Misses 1528 1526 -2 |
f12d1fe
to
67dcf94
Compare
The original half-measure approach in this PR didn't fully work, so I had to do things properly. This means allowing This approach is different from what I attempted in PR #13437. There I converted plain objects to |
dfc7110
to
7570d71
Compare
7570d71
to
8619fe5
Compare
This is needed for type checking purpose. The data is a plain object as before.
2ccc7e7
to
a87efa7
Compare
This PR allows to use string nodes with
StaticLayoutProvider
. Previously only integer keys were allowed. In future this could potentially be generalized to any types, but is out of scope for this particular work. As a side effect of this change, I had to figure out a solution to issue #13378, i.e. resolve deserialization issues of dictionaries. This PR partially supersedes PR #13437. I will refocus that PR from attempting to fix the issue to its actual main point, which is migration from plain objects toMap
type. This PR also removes some leftovers after removal of hammerjs, which I noticed when dealing with some type issues.fixes #12651
fixes #13378