Restore mixed deserialization of dicts #13696
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## branch-3.4 #13696 +/- ##
===========================================
Coverage 92.59% 92.59%
===========================================
Files 323 323
Lines 20575 20590 +15
===========================================
+ Hits 19051 19066 +15
Misses 1524 1524 |
bryevdv
approved these changes
Feb 15, 2024
mattpap
force-pushed
the
mattpap/13637_restore_map_deserialization
branch
from
cda38f4 to
bb0a79c
Compare
Chiemezuo
pushed a commit
to Chiemezuo/bokeh
that referenced
this pull request
Aug 27, 2024
* Rename kinds.{Map->Mapping} to avoid confusion
* Rename kinds to avoid confusion with builtins
* Introduce a common type for major_label_overrides
* Deserialize {type: "map"} as a Map or PlainObject
* Remove special handling from TapToolView
* Update bokehjs' unit tests
* Don't propagate PlainObjectProxy to properties
* Unify border_radius types between bokeh and bokehjs
* Add a cross integration test for issue bokeh#13637
* Better handling of number | string -> V mapping
* Add rudimentary struct support and finish testing
* Rename other colliding kinds and add tests
* Fix type of Selection.multiline_indices in Python
* Allow to {} in Mapping from deserialization
* Allow to configure serialization of defaults
* Add cross integration tests for empty Map case
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR restores deserialization of Python
dictas either a plain object for string keys or aMapfor other kinds of keys. This allows to maintain compatibility, especially for panel and other extensions. All other changes introduced in PR #13618 were kept, allowing for seamless operation on plain objects (as pseudo dicts) andMapat the same time.This PR also adds
settings.serialize_include_defaultsfor testing/debugging, which is used in this PR in new cross integration tests for issue #13637.fixes #13637
addresses #13055