Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/blaze blueprint #1713

Merged
merged 44 commits into from Feb 10, 2015
Merged

Feature/blaze blueprint #1713

merged 44 commits into from Feb 10, 2015

Conversation

hhuuggoo
Copy link
Contributor

No description provided.

@hhuuggoo
Copy link
Contributor Author

#1635

@hhuuggoo hhuuggoo added this to the 0.8 milestone Jan 15, 2015
@bryevdv
Copy link
Member

bryevdv commented Feb 2, 2015

Is PIL only needed for the test? If so, ideal to skip only for py3 but ok to skip altogether for now. If PIL is a real dependency we need to find a py3 pkg or find an alternative.

@pzwang
Copy link

pzwang commented Feb 2, 2015

Can we monkeypatch imresize to work with Pillow on Py3k?
https://github.com/python-pillow/Pillow

In any case, I don't think this test is worth holding up the merge. But definitely create an issue for this.

@hhuuggoo
Copy link
Contributor Author

hhuuggoo commented Feb 2, 2015

oh great! looks like if we install pillow then scipy.misc.imresize exists in both py3 and py2

@hhuuggoo hhuuggoo mentioned this pull request Feb 2, 2015
7 tasks
@damianavila
Copy link
Contributor

Just a corner comment: Nice to see Pillow enable the imresize... some time ago I tested with Pillow and it was not working so I switched to PIL... Pillow is better, so great it is working!

@bryevdv
Copy link
Member

bryevdv commented Feb 3, 2015

@hhuuggoo is this ready? It needs some docs for the examples, I can add some tomorrow but it would be good to merge this tomorrow if possible.

@hhuuggoo
Copy link
Contributor Author

hhuuggoo commented Feb 3, 2015

you mean comments on examples? I was going to add some sphinx docs, but I wanted to do that separately (unless you prefer in same pr, but this is getting large)

Yes I think this is ready after a review - there are some usability enhancements to make, but again - separate PR.

Before merging we should have a discussion about dependencies. The additional dependencies are

  • blaze (current production release)
  • into (based on master - I have a conda package in the bokeh channel)
  • multiuserblazeserver (based on master - I have a conda package)

Not sure if you want to wait for a real into release - I can talk to @mrocklin about that, he said it would not take long to push one out. I can release the multiuserblazeserver immediately

@mrocklin
Copy link
Contributor

mrocklin commented Feb 3, 2015

I technically did a release for into a couple hours ago (version 0.1.4). I didn't publicize it though (well except for this blogpost about into generally) and will likely release again before strata.

I've also been thinking about making two blaze packages, one with minimal dependencies (numpy, pandas, into, sqlalchemy) and one with everything (hdf5, bcolz, ...) If this would ease hearts and minds in bokeh-land let me know.

@bryevdv
Copy link
Member

bryevdv commented Feb 3, 2015

BTW can we just call it blaze-server or if we must, multiuser-blaze-server

@hhuuggoo
Copy link
Contributor Author

hhuuggoo commented Feb 4, 2015

@JosephCottam can you have a look?

thanks

@JosephCottam
Copy link

The changes look solid, but not all of the server examples are updated as yet.

Of the files in examples/plotting/server that use remote data sources, only blaze_source.py and abstractrender.py are currently working. census.py, remote_image.py, serversource.py all fail on client-side execution due to changes in datasource setup parameters.

@hhuuggoo
Copy link
Contributor Author

@JosephCottam I think census was the only one I didn't update - serversource, remote_image should have all been updated i thought? what is the error you are getting? I am getting additional errors on a few examples due to color maps being missing - I think this is unrelated and we should merge and then fix that problem later

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants