#2904 - fixed a bug editing a sorted or filtered datatable

[dennisobrien]

#2904 - fixed a bug when a table was sorted by a column other than the index then edited.

supersede #2906

This changes the semantics of getItem/setItem to use an offset into the data array, while getField/setField still take an item index. The index and the offset will be the same for a data array that is sorted by the index field and has not been filtered.

[dennisobrien]

I'm confused by this Travis CI build failure. The failure is reported in examples/compat/ggplot/density.py but it's not clear to me how that is connected to the changes I made in bokehjs/src/coffee/widget/data_table.coffee.

I'll try to hunt this down.

>>> Testing /home/travis/build/bokeh/bokeh/examples/compat/ggplot/density.py ...
[WARN] Timeout
[FAIL] failed to load file:///home/travis/build/bokeh/bokeh/examples/compat/ggplot/density.html

[canavandl]

I restarted the Travis build and it passed. It looks like it was a spurious timeout.

LGTM (and thanks for contributing)

[birdsarah]

Tested locally on the data_tables.py example as per instructions in #2904 - works great.

Thanks for the contribution and thanks for the knowledge that you can edit cells on DataTable - that has blown my mind :D