Fix autoload templates to inject data into JS templates properly #5603
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Don't rely on Python's str() being valid JS.
|
Works for me after testing (a screenshot of output here would have saved me the trouble tho) |
azjps
pushed a commit
to azjps/bokeh
that referenced
this pull request
Dec 28, 2016
…eh#5603) * Add support for `json` jinja2 filter * Use json filter to inject data into JS templates Don't rely on Python's str() being valid JS. * Add a default value for `force` argument to autoload_js template
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we relied on Python's
str()returning valid JS. Sometimes it actually and very deceptively does.fixes #5558