Tornado 5 Compatibility #7329
Merged
Tornado 5 Compatibility #7329
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
bryevdv
commented
Dec 17, 2017
•
bryevdv
commented
- issues: fixes Tornado 5.0 compatibility #7308
- tests added / passed
- release document entry (if new feature or API change)
|
@mrocklin did you have a chance to test with this PR? I am going to do some more but it would be good to have more data points. I'd like to merge this then make a separate issue for updating the CI to test with both tornado 4 and 5 later. |
|
No, I haven't. I invested the time to set up a decent bokeh dev setup on
this machine.
…On Thu, Feb 1, 2018 at 10:25 AM, Bryan Van de Ven ***@***.***> wrote:
@mrocklin <https://github.com/mrocklin> did you have a chance to test
with this PR? I am going to do some more but it would be good to have more
data points. I'd like to merge this then make a separate issue for updating
the CI to test with both tornado 4 and 5 later.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#7329 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AASszC8bLwd_OUw_7YIIa_n9OqNvM-iUks5tQdeGgaJpZM4RE09m>
.
|
|
I *haven't* invested
…On Thu, Feb 1, 2018 at 10:32 AM, Matthew Rocklin ***@***.***> wrote:
No, I haven't. I invested the time to set up a decent bokeh dev setup on
this machine.
On Thu, Feb 1, 2018 at 10:25 AM, Bryan Van de Ven <
***@***.***> wrote:
> @mrocklin <https://github.com/mrocklin> did you have a chance to test
> with this PR? I am going to do some more but it would be good to have more
> data points. I'd like to merge this then make a separate issue for updating
> the CI to test with both tornado 4 and 5 later.
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> <#7329 (comment)>, or mute
> the thread
> <https://github.com/notifications/unsubscribe-auth/AASszC8bLwd_OUw_7YIIa_n9OqNvM-iUks5tQdeGgaJpZM4RE09m>
> .
>
|
|
Unit tests pass and a selection of app examples seem to run as expected in both t4 and t5 environments, so I am going to go ahead and merge to get into a dev build |
|
Thanks Bryan
…On Thu, Feb 1, 2018 at 10:43 AM, Bryan Van de Ven ***@***.***> wrote:
Merged #7329 <#7329>.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#7329 (comment)>, or mute the
thread
<https://github.com/notifications/unsubscribe-auth/AASszBvTG_fqO9F_sLzH_1QuKdYSqOUwks5tQdu7gaJpZM4RE09m>
.
|
|
Dev builds happen nightly or on merge to master?
…On Thu, Feb 1, 2018 at 10:44 AM, Matthew Rocklin ***@***.***> wrote:
Thanks Bryan
On Thu, Feb 1, 2018 at 10:43 AM, Bryan Van de Ven <
***@***.***> wrote:
> Merged #7329 <#7329>.
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> <#7329 (comment)>, or mute the
> thread
> <https://github.com/notifications/unsubscribe-auth/AASszBvTG_fqO9F_sLzH_1QuKdYSqOUwks5tQdu7gaJpZM4RE09m>
> .
>
|
|
They are explicitly triggered. I will try to get one out today. |
|
@mrocklin |
|
Thanks, I'll try things out and report back.
…On Thu, Feb 1, 2018 at 3:31 PM, Bryan Van de Ven ***@***.***> wrote:
@mrocklin <https://github.com/mrocklin> 0.12.14dev7 is available
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#7329 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AASszC2SxnQd45rS0Q8I-jtAVQuG8Stoks5tQh8PgaJpZM4RE09m>
.
|
|
From a dask perspective bokeh + tornado 5.0 run well. Thanks for the
efforts here.
…On Thu, Feb 1, 2018 at 3:31 PM, Matthew Rocklin ***@***.***> wrote:
Thanks, I'll try things out and report back.
On Thu, Feb 1, 2018 at 3:31 PM, Bryan Van de Ven ***@***.***
> wrote:
> @mrocklin <https://github.com/mrocklin> 0.12.14dev7 is available
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> <#7329 (comment)>, or mute
> the thread
> <https://github.com/notifications/unsubscribe-auth/AASszC2SxnQd45rS0Q8I-jtAVQuG8Stoks5tQh8PgaJpZM4RE09m>
> .
>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.