Fix broken generic text legend. #7360
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR updates 'draw_legend_for_index' to get/set visuals from new locations. However, even with this PR, legends for text glyphs do not seem very useful. The legend always renders "text" in 10pt, only matching color and style. More input and work is needed to make a more useful text legend.
bryevdv
force-pushed
the
bryanv/7337_text_legend
branch
from
c9ce758
to
f0e60c3
Compare
bryevdv
force-pushed
the
bryanv/7337_text_legend
branch
from
f0e60c3
to
5d323ce
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates
draw_legend_for_indexrender empty space in legends. The previous implementation simply rendered the word "text" unconditionally which is not useful. Now text glyphs can added to legends in combination with other glyphs in order to be able to hide or mute them together:issues: fixes #7337