Fix type errors in models/sources #7599
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattpap
force-pushed
the
mattpap/6481_ts35
branch
from
c5444cf
to
f8f67b8
Compare
mattpap
force-pushed
the
mattpap/6481_ts35
branch
from
9286a50
to
d4720a6
Compare
mattpap
force-pushed
the
mattpap/6481_ts35
branch
from
d4720a6
to
fad1064
Compare
bryevdv
approved these changes
Mar 8, 2018
|
OK will merge this and get a dev build out |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is another painful rewrite (after ui_events and serialization), because
data_source.datacan mix arrays with typed arrays, but most code doesn't bother to account for that, and when it does, it does this in atrocious ways.addresses #6481