Allow loading cached compiled models using hook #8336
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philippjfr
force-pushed
the
philippjfr/5345_compiled_model_hook
branch
2 times, most recently
from
967c3ae
to
091d164
Compare
philippjfr
force-pushed
the
philippjfr/5345_compiled_model_hook
branch
from
091d164
to
a7d4e3b
Compare
3 tasks
bryevdv
approved these changes
Oct 16, 2018
|
Merging this scaled back PR with only minor dev API hooks added. With some more experience of real world usage we can come back to adding a more public capability later. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simplified implementation for loading cached compiled models until we settle on a public API. Works by allowing users to set a cache hook which should return the compiled code given the uncompiled implementation. Offers public methods to get and set this hook, available as:
Also splits the compilation code a bit so that it is easier for an external library to pre-compile a model and load it in the cache hook it registers.