Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Serialize multiple vcard generate wrong start/end frame #55

Closed
rallets opened this issue Jun 16, 2022 · 4 comments
Closed

Serialize multiple vcard generate wrong start/end frame #55

rallets opened this issue Jun 16, 2022 · 4 comments

Comments

@rallets
Copy link
Contributor

rallets commented Jun 16, 2022

Hi, I'm serializing multiple vcards, and the Start/End frame is generated on the same line, breaking the import in Android.
Basically it generates a vard that looks like

[...]
GENDER:None
END:VCARDBEGIN:VCARD
VERSION:3.0
[...]

but I'm expecting

[...]
GENDER:None
END:VCARD
BEGIN:VCARD
VERSION:3.0
[...]

Any tips?
Thank you

@rallets
Copy link
Contributor Author

rallets commented Jun 20, 2022

@bolorundurowb I have sent a PR to fix these two issues, with related unit tests, could you take a look? are you interested in merging them?
Thank you

@bolorundurowb
Copy link
Owner

Approved the PR, but there is a failing test due to the line endings \r and the test runner expecting \r\n. You can replace the line endings in your string with Envrionment.NewLine

@nordfish-it
Copy link

@bolorundurowb I updated the PR and it looks the tests are passing now. Can you merge and generate a new release?
Thank you!

@rallets
Copy link
Contributor Author

rallets commented Jun 22, 2022

Tks!

@rallets rallets closed this as completed Jun 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants