Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Duration __eq__ method should not raise NotImplementedError #24

Open
coopstah13 opened this issue Oct 11, 2022 · 0 comments
Open

Duration __eq__ method should not raise NotImplementedError #24

coopstah13 opened this issue Oct 11, 2022 · 0 comments

Comments

@coopstah13
Copy link

This prevents equality checks with different objects than other Duration objects.
Also should not be doing this in __add__, __sub__ or __rsub__ either.

See https://docs.python.org/3.11/library/constants.html#NotImplemented
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@coopstah13