Omnisearch listing reloaded #4252
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
rarila
commented
Oct 10, 2015
rarila
commented
- Simplified how the landingpage is remove from search results
- Show all results again, not only contenttypes and files edits
- Added a $fonts-family-monospace sass variable
- Fixed wrong theme file edit path in omnisearch
|
Seems to work smoothly. One thing i've noticed: When i'm typing, it briefly shows "undefined". See screenshot:
I'm going to rebuild the .js, to see if that's not the issue. edit: Nope, rebuilding was not the solution. |
|
@bobdenotter Nothing changed in that PR that could cause this, the AJAX response looks good and my local master branch has the same behavior. |
|
All is well, then! Merging in! :-) |
bobdenotter
added a commit
that referenced
this pull request
Oct 11, 2015
Omnisearch listing reloaded
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.