Refinements for content fetching #5401
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rossriley
changed the title
| } else { | ||
| $contentQuery->setParameter('slug', $contentQuery->getIdentifier()); | ||
| } | ||
| if(count($contentQuery->getContentTypes()) === 1) { |
There was a problem hiding this comment.
Expected 1 space after IF keyword; 0 found
^ this 👍 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements the missing named record select in the new storage engine.
It includes the intelligence to drop into single record mode where appropriate and thus means the following queries will all work correctly.
$page = $app['query']->getContent('pages/2'); // returns a single page with an id of 2$page = $app['query']->getContent('pages/lorem-ipsum'); // returns a single page with aslug of 'lorem-ipsum'$pages = $app['query']->getContent('pages,entries/2'); // returns multiple records where id is 2Fixes: #5395
There's also corresponding test updates to reflect these changes, which should have no BC implications since it was functionality that was not correctly implemented before.