Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.3] Replacing RandomLib #6021

Merged
merged 6 commits into from
Nov 10, 2016
Merged

[3.3] Replacing RandomLib #6021

merged 6 commits into from
Nov 10, 2016

Conversation

GwendolenLynch
Copy link
Contributor

In an effort to get PHP 7.1 a happening thing, and per RFC #5893 … removal of RandomLib use in core.

This PR maintains a service under $app['randomgenerator'] for BC.

There is a corner-case BC break with this PR, where someone is type hinting on the service itself, which would be pretty rare.

Imports

use RandomLib\Generator;

to:

use Bolt\Security\Random\Generator;

Function signatures

In the case of a fully namespaced function hint:

function foo(\RandomLib\Generator $generator)
{
}

to

use Bolt\Security\Random\Generator;

// …

function foo(Generator $generator)
{
}

Would generally suffice.

@GwendolenLynch GwendolenLynch added this to the Bolt 3.3 - Feature release milestone Nov 10, 2016
@bobdenotter
Copy link
Member

Looks good to me!

@bobdenotter bobdenotter merged commit 9901ec2 into bolt:release/3.3 Nov 10, 2016
@GwendolenLynch GwendolenLynch deleted the feature/replacing-randomlib branch November 10, 2016 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants