Modded core's select field to accommodate for multiple contenttypes v2 #6299
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuing on from #6270 and the discussion had with @SahAssar I've modified the original implementation of this slightly so instead of determining the return value based on the existence of
contenttype
it instead does it based on whether multiple contenttypes have been defined. This separates the left hand side of the values string from the right more distinctly and allows more refined choice for the developer.Would create a select option with
<option value="event/1">Title</option>
.While
Would create a select option with
<option value="1">Event / Title</option>
I know that it's already been merged in as is - happy for this to be closed without being pulled if everyone is more happy with the first implementation. I'm also always looking for feedback 😄