Deprecate Render #6310
Merged
Deprecate Render #6310
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ect. Name is really the only thing useful from the object since it's already rendered. Not to mention Twig_Template is marked as internal.
CarsonF
force-pushed
the
deprecate-render
branch
from
9ba05d7
to
8cef736
Compare
GwendolenLynch
approved these changes
Jan 28, 2017
Yeah, I was in two minds about that too, when it was implemented. But TBH the string is all I personally would need from there, so 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deprecate
RenderRender::renderis the last non-deprecated method in the class, and it is now just a shortcut to render template toTemplateResponse. As a shortcut, it makes more sense to do the logic in the Base Controller with the other shortcut methods.It also gets simpler once the globals go away (to be deprecated later in 3.x).
I also changed
TemplateResponseto take template name instead of template object.Name is really the only thing useful from the object since it's already rendered.
Not to mention
Twig_Templateis marked as internal.