[3.4] Composer script logic for default site bundle #7071
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I like it.. From what I glean by looking at it, this would fit well with how I personally see people using bolt most (getting the distro, running composer for updates or just using |
xiaohutai
reviewed
Oct 12, 2017
src/Nut/Init.php
Outdated
| private function updateDistBundles() | ||
| { | ||
| $fs = $this->app['filesystem']->getFilesystem('root'); | ||
| $paths = ['.bolt.yml', 'composer.json', 'composer.lock', 'src/Site/SiteBundleLoader.php']; |
There was a problem hiding this comment.
Don't you prefer:
$paths = [
'.bolt.yml',
'composer.json',
'composer.lock',
'src/Site/SiteBundleLoader.php',
];
There was a problem hiding this comment.
Haha … Payback is the proverbial … yeah, probably. I don't know that this is exactly what we want either way, just trying to keep the conversation moving right now 😉
bobdenotter
approved these changes
Oct 18, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Discussion: bolt/composer-install#28