-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Default site bundle #28
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As discussed on #development, I'm 👍, if we add this to app/nut init
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Other than. .bolt.yml. Since that file is generated anyways, maybe we can add logic there to check if the SiteExtension
class exists and add it to the extensions section.
I don't see the need for it to be in nut init
.
That one is due to the nature of archive installs, basically that the archive distribution should rename the PHP file to a |
Sounds like an idea … for Thursday's task list |
Archive installs run the script handler when they are being created so it will still have that logic. Either way this boilerplate for new installs, not upgrades.
👍 |
OK, I am missing the obvious here … potentially. A new install is a distribution install, there is no differentiation due to the fact it can be either new or an upgrade, it just replaces files. So if you install an archive and it includes |
No you're right. It just replaces files, so .dist files are needed. But as far as |
905f862
to
e768d31
Compare
Depends. It is about barrier to entry though. Generally, installs are staged somewhere first. In that case, running Nut is easy … downloading and using Composer ¯_(ツ)_/¯ … this whole concept gives people something to work off of that is already autoloadable, etc, to get up and running. |
7f760a2
to
35de391
Compare
As discussed: Let's get this in, as it's a big improvement as it stands. |
Please treat this as RFC status until we've all had a chance to chime in.
Problem
People without much exposure to Composer & PHP generally want to add small additions to the site, when this "looks" too hard, they often make feature requests for things that don't belong in core.
Concept
My proposed, PoC, solution here is the addition of a "site bundle" that people can use to build on, quickly!
e.g.
For those of us that want to customise, and RTFM, we can just delete/rename/modify or just 🐨 until our hearts are content.
Caveat
What to do about archive distributions?
Probably best to make
.bolt.yml
into.bolt.yml.dist