Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tags in non-english languages and firefox caching selected options #7822

Merged
merged 2 commits into from Nov 10, 2019

Conversation

SahAssar
Copy link
Contributor

@SahAssar SahAssar commented Nov 4, 2019

This fixes two issues:

  1. Bolt saw the slug and the name of a tag as always equivalent, this makes them distinct
  2. Firefox has a "feature" where it ignores selected if a different option has been selected before reload and the reload is not "hard". Since select2 takes over the actual input it didn't see the select as changed, so adding a tag and reloading would make it seem like the tag wasn't added, and then a subsequent save would remove the tag.

Fixes: #7659

@SahAssar SahAssar closed this Nov 4, 2019
@SahAssar SahAssar reopened this Nov 4, 2019
bobdenotter
bobdenotter previously approved these changes Nov 4, 2019
Copy link
Member

@bobdenotter bobdenotter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

adding a tag and reloading would make it seem like the tag wasn't added, and then a subsequent save would remove the tag

I've always seen this as a "unfortunate fact of life", but i'm happy to have a fix for it! 👍

@bobdenotter
Copy link
Member

There's one failure, on PHP 7.2 only, that says:

Screenshot 2019-11-04 at 21 20 32

It's peculiar though, because I don't readily see how this change could cause that as a side effect.. 🤔

@bobdenotter
Copy link
Member

Still the same weird failure on 7.2 only.. I guess you don't see how this could be caused by your changes either, right?

@SahAssar
Copy link
Contributor Author

SahAssar commented Nov 5, 2019

Nope, no idea... I'll try too find out.

@SahAssar
Copy link
Contributor Author

SahAssar commented Nov 5, 2019

I can't find why my changes would lead to that failure...

@bobdenotter bobdenotter merged commit 493fe01 into 3.6 Nov 10, 2019
@bobdenotter bobdenotter deleted the bug/fix-select-i18n-and-FF branch November 10, 2019 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Duplicate tags in tag field
2 participants