Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Repair setcontent #286

Merged
merged 6 commits into from Jan 23, 2019
Merged

Repair setcontent #286

merged 6 commits into from Jan 23, 2019

Conversation

xiaohutai
Copy link
Member

Fixes issues #282 and #283

This PR removes some type hints which is not a nice thing to do in general, but I don't know how to circumvent these issues in a nice way. Below is a summary.

Notes

@JarJak
Copy link
Member

JarJak commented Jan 22, 2019

the base part like pages or pages/1
parameters like printquery, paging
actual where parameters taken from ... where { foo: bar } ...

Could you explain those e.g. in the comment above getContentForTwig?

@xiaohutai
Copy link
Member Author

No need for typehinting in phpdoc if they already exists, right?

@JarJak
Copy link
Member

JarJak commented Jan 22, 2019

@xiaohutai if checkers won't complain, yes

EDIT: actually they complain so please add them

@xiaohutai
Copy link
Member Author

It's stricter than I thought 😅

Copy link
Member

@bobdenotter bobdenotter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works like a charm! 👍

@bobdenotter
Copy link
Member

(And my apologies for breaking stuff ;-) )

@xiaohutai
Copy link
Member Author

No, worries. It's actually to show that it's PHPStan complaining about things. Unless those parts are coded differently we can't really add those nice type hints yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants