Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Yet another setcontent fix #288

Merged
merged 1 commit into from Jan 24, 2019
Merged

Yet another setcontent fix #288

merged 1 commit into from Jan 24, 2019

Conversation

JarJak
Copy link
Member

@JarJak JarJak commented Jan 23, 2019

Inspired by PR by Xiao #286.

Fixes #282 and #283.

This PR can wait for porting setcontent tests from Bolt 3.x #289

@JarJak
Copy link
Member Author

JarJak commented Jan 23, 2019

Looks like kakunin needs additional step to set status of page to published :)

@JarJak
Copy link
Member Author

JarJak commented Jan 24, 2019

I'll rebase this PR on master and fix it for setcontent tests if needed

Copy link
Member

@bobdenotter bobdenotter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests passing! 👍

@JarJak JarJak merged commit 3949b04 into master Jan 24, 2019
@bobdenotter bobdenotter deleted the fix/setcontent branch January 24, 2019 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants