Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Editing relations #418

Closed
wants to merge 49 commits into from

Conversation

@bobdenotter
Copy link
Member

commented May 7, 2019

Fixes #330. Fixes #329.

@bobdenotter

This comment has been minimized.

Copy link
Member Author

commented May 7, 2019

When editing + saving a record, I get the following exception:

Screenshot 2019-05-07 at 21 27 39

If I comment out the two lines that modify the relations, it works as before (minus persisting the changed relations, obviously..

        // Remove old ones
        foreach ($currentRelations as $currentRelation) {
            // $this->em->remove($currentRelation);
        }

        // Then (re-) add selected ones
        foreach ($relation as $id) {

            // $this->em->persist($relation);
        }

@bobdenotter bobdenotter added this to the Bolt 4 beta 1 milestone May 8, 2019

@JarJak

This comment has been minimized.

Copy link
Member

commented May 8, 2019

@bobdenotter I suppose this is a bug in Gedmo. For some reason Sortable conflicts with Translatable here, even if Relation is not a translatable entity.

bobdenotter added some commits May 8, 2019

Merge pull request #417 from bolt/javascript-use-luxon-instead-of-moment
Update packages, add Luxon, reduce flag sizes
Merge pull request #420 from bolt/fix/attributes-in-json_records
[hotfix] Add missing attributes to json_records

bobdenotter added some commits May 10, 2019

Merge pull request #421 from bolt/fix/cache-widgets
Allow for caching of widgets
Merge pull request #423 from bolt/hotfix/tiny-npm-updates
[hotfix] Update package.json: tiny npm updates
Merge pull request #422 from bolt/hotfix/bug-in-injector-regex
Fix bug in injector where it confused tags like `head` and `header`
Merge pull request #427 from bolt/working-on-dashboard
Make Dashboard / Listing pages look better
Merge pull request #431 from bolt/chore/composer-cleanup
[chore] Cleanup of composer.json

@bobdenotter bobdenotter force-pushed the editing-relations branch from 0ec8842 to bdd77fa May 22, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.