Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RFC] LoginPasswordType - Remove password length constraint. #28

Closed
artggd opened this issue May 14, 2018 · 1 comment
Closed

[RFC] LoginPasswordType - Remove password length constraint. #28

artggd opened this issue May 14, 2018 · 1 comment

Comments

@artggd
Copy link
Contributor

artggd commented May 14, 2018

Hi,

The form LoginPasswordType has a constraint on the password length. This kind of constraint is useful for password creation / update but not much for the login form.

My issue here is that I'm extending BoltAuth by adding a custom AuthorisationHandler to allow my users to login through a webservice. Some of these existing users have passwords with less than 6 characters.

I could override the form itself but I reckon this constraint could simply be removed because it also gives a potential attacker a clue on the passwords hashed in the database.

Alternatively, making the length configurable could be a solution.

@SvanteRichter
Copy link
Collaborator

I usually like the current NIST guidelines for these sort of things;

Memorized secrets SHALL be at least 8 characters in length if chosen by the subscriber.

from https://pages.nist.gov/800-63-3/sp800-63b.html#reqauthtype

But, adding a option to configure the minlength seems fine by me as long as it defaults to 6 or 8

@artggd artggd closed this as completed Feb 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants