Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pattern Lab UIKit Cross Browser Fixes #1590

Merged
merged 1 commit into from
Dec 4, 2019

Conversation

sghoweri
Copy link
Contributor

@sghoweri sghoweri commented Dec 4, 2019

Jira

N/A

Summary

Handful of cross browser JS fixes (IE 11 mostly) I ran into the need for while testing out the ES Module-related work in #1579.

Also includes the Edge polyfill issue fixed upstream in pattern-lab/patternlab-node#1105

@sghoweri
Copy link
Contributor Author

sghoweri commented Dec 4, 2019

@remydenton @adamszalapski @mikemai2awesome @danielamorse Since these are only changes that relate to Pattern Lab's internal JavaScript (non-visual + non-functional, other than things not being broken in some browsers), I'm going to move forward with getting this low risk PR merged down so we can spend our time focusing on other higher priority items!

@sghoweri sghoweri added the bug label Dec 4, 2019
@sghoweri sghoweri merged commit 557cd3d into master Dec 4, 2019
@sghoweri sghoweri deleted the feature/esmodule-support--uikit-updates branch December 4, 2019 22:14
@sghoweri
Copy link
Contributor Author

PR was released with v2.13.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant