UIKit Polyfill Hotfix for Edge #1105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Edge supports ES modules but NOT Custom Elements
|
EDIT: tested and confirmed to be working as expected in Chrome, Safari and Firefox (all on MacOS) plus Edge 18 and IE 11 on Windows 10 |
bmuenzenmeyer
approved these changes
Nov 26, 2019
|
Thanks @bmuenzenmeyer! |
antonia-rose
pushed a commit
to quelltexterin/nemo-uikit-workshop
that referenced
this pull request
Apr 12, 2023
…fill-fix UIKit Polyfill Hotfix for Edge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hotfix workaround to address a gap in our polyfill strategy. Basically the latest version of Edge supports ES modules but NOT custom elements, hence doesn't load the necessary polyfills that non-ES module supporting browsers would normally get.
We need to test and confirm that this workaround works as expected in other modern browsers (Chrome, Safari, FF) — quick testing in Chrome looked fine but just want to double-check before releasing.
Closes #1104